Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Release parachain host API v4 #6885

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Release parachain host API v4 #6885

merged 1 commit into from
Mar 15, 2023

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn commented Mar 15, 2023 •
edited
Loading

Prepare parachain host API v3 v4 for release (#6292)

Cumulus companion: paritytech/cumulus#2325

@s0me0ne-unkn0wn s0me0ne-unkn0wn added the A0-please_review Pull request needs code review. label Mar 15, 2023
@paritytech-ci paritytech-ci requested review from a team March 15, 2023 12:23
eskimor
eskimor approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paritytech-ci paritytech-ci requested a review from a team March 15, 2023 13:37
@ordian ordian added C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T2-API This PR/Issue is related to APIs. B1-note_worthy Changes should be noted in the release notes labels Mar 15, 2023
ordian
ordian approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I be targeting api_version(5) for #6667 after this change?

@tomaka
Copy link
Contributor

tomaka commented Mar 15, 2023 •
edited
Loading

Shouldn't this go through a proposal? https://github.com/w3f/PPPs
I realized that nobody seems to give a shit about these proposals at the moment, but if we are to ever become a serious platform it should eventually become the norm that all changes to the runtime <-> host interface are explained and documented.

@s0me0ne-unkn0wn
Copy link
Contributor Author

What about polkadot core primitives, does their version come together with other primitives? We have v2 module in core-primitives, but it's a stub that only does pub use super::*. Should I bump it to v4 or let it live its own life?

@bkchr
Copy link
Member

bkchr commented Mar 15, 2023

Shouldn't this go through a proposal? https://github.com/w3f/PPPs I realized that nobody seems to give a shit about these proposals at the moment, but if we are to ever become a serious platform it should eventually become the norm that all changes to the runtime <-> host interface are explained and documented.

For the long term yes! For now, we started with host functions as I promised. No new host functions without a RFC. I will also in the near future ensure that we start merging there stuff!

@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this pull request Mar 15, 2023
Merged
@tomaka tomaka mentioned this pull request Mar 15, 2023
Closed
@s0me0ne-unkn0wn
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit c717dbb into master Mar 15, 2023
@paritytech-processbot paritytech-processbot bot deleted the s0me0ne/release-v4 branch March 15, 2023 17:06
ordian added a commit that referenced this pull request Mar 16, 2023
@ordian
Merge branch 'master' into ao-kusama-enable-dispute-slashes
05dc083 
* master: (50 commits)
  Issue 4393: Correcting Unnecessary Use of Arc (#6882)
  Companion for #13287  (#6655)
  timestamp ci job logs (#6890)
  Release parachain host API v4 (#6885)
  polkadot companion: #13128 (Pools commission) (#6264)
  companion for #13555 (#6842)
  Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600)
  Bump bumpalo from 3.8.0 to 3.12.0 (#6599)
  Bump git2 from 0.16.0 to 0.16.1 (#6601)
  Council as SpendOrigin (#6877)
  PVF: Document that preparation cannot lead to disputes (#6873)
  Sync versions with current release (0.9.39) (#6875)
  Companion for paritytech/substrate#13592 (#6869)
  Update orchestra to the recent version (#6854)
  Delete unused Cargo.lock (#6870)
  Remove use of Store trait (#6835)
  Companion for Substrate #13564 (#6845)
  Adding Dispute Participation Metrics (#6838)
  Update `substrate` to 48e7cb1 (#6851)
  Move PVF timeouts to executor environment parameters (#6823)
  ...
ordian added a commit that referenced this pull request Mar 21, 2023
@ordian
Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…
b3b094c 
…slashing-client

* ao-past-session-slashing-runtime: (23 commits)
  Issue 4393: Correcting Unnecessary Use of Arc (#6882)
  Companion for #13287  (#6655)
  timestamp ci job logs (#6890)
  Release parachain host API v4 (#6885)
  polkadot companion: #13128 (Pools commission) (#6264)
  companion for #13555 (#6842)
  Bump libgit2-sys from 0.14.1+1.5.0 to 0.14.2+1.5.1 (#6600)
  Bump bumpalo from 3.8.0 to 3.12.0 (#6599)
  Bump git2 from 0.16.0 to 0.16.1 (#6601)
  Council as SpendOrigin (#6877)
  PVF: Document that preparation cannot lead to disputes (#6873)
  Sync versions with current release (0.9.39) (#6875)
  Companion for paritytech/substrate#13592 (#6869)
  Update orchestra to the recent version (#6854)
  Delete unused Cargo.lock (#6870)
  Remove use of Store trait (#6835)
  Companion for Substrate #13564 (#6845)
  Adding Dispute Participation Metrics (#6838)
  Update `substrate` to 48e7cb1 (#6851)
  Move PVF timeouts to executor environment parameters (#6823)
  ...
@ordian ordian mentioned this pull request Jun 7, 2023
Merged
6 tasks
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@simonsso simonsso mentioned this pull request Jun 16, 2023
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrcnski mrcnski mrcnski left review comments

@ordian ordian ordian approved these changes

@tdimitrov tdimitrov tdimitrov left review comments

@eskimor eskimor eskimor approved these changes

@sandreim sandreim Awaiting requested review from sandreim

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T2-API This PR/Issue is related to APIs.
Projects
No open projects
Parachains-core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@s0me0ne-unkn0wn @tomaka @bkchr @tdimitrov @eskimor @ordian @mrcnski