Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF: Don't dispute on missing artifact #7011

Merged
merged 7 commits into from
Apr 20, 2023

Commits on Apr 5, 2023

  1. PVF: Don't dispute on missing artifact

    A dispute should never be raised if the local cache doesn't provide a certain
    artifact. You can not dispute based on this reason, as it is a local hardware
    issue and not related to the candidate to check.
    
    Design:
    
    Currently we assume that if we prepared an artifact, it remains there on-disk
    until we prune it, i.e. we never check again if it's still there.
    
    We can change it so that instead of artifact-not-found triggering a dispute, we
    retry once (like we do for AmbiguousWorkerDeath, except we don't dispute if it
    still doesn't work). And when enqueuing an execute job, we check for the
    artifact on-disk, and start preparation if not found.
    
    Changes:
    
    - [x] Integration test (should fail without the following changes)
    - [x] Check if artifact exists when executing, prepare if not
    - [x] Return an internal error when file is missing
    - [x] Retry once on internal errors
    - [x] Document design (update impl guide)
    mrcnski committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6b66e91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fa0046 View commit details
    Browse the repository at this point in the history
  3. Fix impl guide

    mrcnski committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d1a3050 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Configuration menu
    Copy the full SHA
    5982b8b View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Configuration menu
    Copy the full SHA
    ff77e2a View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Configuration menu
    Copy the full SHA
    b450803 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Merge remote-tracking branch 'origin/master' into mrcnski/pvf-missing…

    …-artifact
    parity-processbot committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9259f72 View commit details
    Browse the repository at this point in the history