Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Substrate Companion #7118

Merged
merged 11 commits into from
May 11, 2023
Merged

Substrate Companion #7118

merged 11 commits into from
May 11, 2023

Conversation

Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Apr 23, 2023 •
edited by ggwpez
Loading

@Doordashcon Doordashcon mentioned this pull request Apr 23, 2023
Merged
muharem
muharem reviewed Apr 26, 2023
View reviewed changes
runtime/test-runtime/src/lib.rs
@@ -463,6 +463,7 @@ impl pallet_vesting::Config for Runtime {
impl pallet_sudo::Config for Runtime {
type RuntimeEvent = RuntimeEvent;
type RuntimeCall = RuntimeCall;
type WeightInfo = ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to run the benches, and use an actual weight for of runtimes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, can we call a bot to do that like is done on the Substrate repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but I think it wont work until substrate is not merged
You can copy the weights from substrate. During the release process they will be replaced by actual weights.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for Rococo/Westend. For the testing runtimes it does not matter.

ggwpez
ggwpez reviewed May 9, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weights will be updated before the next release.

runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2813108

@ggwpez ggwpez added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 10, 2023
@ggwpez ggwpez requested a review from muharem May 10, 2023 20:35
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Response error (status 500 Internal Server Error): 

{"error_message":""}

@ggwpez
Copy link
Member

ggwpez commented May 11, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 0d09701 into paritytech:master May 11, 2023
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@boundless-forest boundless-forest mentioned this pull request Jul 17, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@muharem muharem Awaiting requested review from muharem

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Doordashcon @paritytech-cicd-pr @ggwpez @sam0x17 @muharem