This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderobe
added
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
T1-runtime
This PR/Issue is related to the topic “runtime”.
B1-note_worthy
Changes should be noted in the release notes
labels
Apr 29, 2023
15 tasks
Comment on lines
-135
to
+137
Weight::from_parts(1_097_373_000, 0) | ||
.saturating_add(Weight::from_parts(0, 8850)) | ||
// Standard Error: 97_518 | ||
.saturating_add(Weight::from_parts(3_170_650, 0).saturating_mul(i.into())) | ||
// Standard Error: 97_518 | ||
.saturating_add(Weight::from_parts(3_304_346, 0).saturating_mul(e.into())) | ||
// Measured: `158 + e * (100 ±0) + i * (100 ±0)` | ||
// Estimated: `3620 + e * (2575 ±0) + i * (2575 ±0)` | ||
// Minimum execution time: 1_068_293_000 picoseconds. | ||
Weight::from_parts(2_873_264, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge jump down
EgorPopelyaev
approved these changes
May 2, 2023
coderobe
commented
May 2, 2023
Comment on lines
-55
to
+56
Weight::from_parts(WEIGHT_REF_TIME_PER_NANOS.saturating_mul(6_818_965), 0); | ||
Weight::from_parts(WEIGHT_REF_TIME_PER_NANOS.saturating_mul(3_467_068), 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block execution weights halved
@s3krit looks like your thing didn't trigger |
chevdor
approved these changes
May 2, 2023
Looking into it, cheers |
vanderian
pushed a commit
to gasp-xyz/polkadot
that referenced
this pull request
Jul 25, 2023
* polkadot: update weights * westend: update weights * kusama: update weights * rococo: update weights
vanderian
pushed a commit
to gasp-xyz/polkadot
that referenced
this pull request
Jul 26, 2023
* polkadot: update weights * westend: update weights * kusama: update weights * rococo: update weights
vanderian
pushed a commit
to gasp-xyz/polkadot
that referenced
this pull request
Jul 26, 2023
* polkadot: update weights * westend: update weights * kusama: update weights * rococo: update weights
vanderian
pushed a commit
to gasp-xyz/polkadot
that referenced
this pull request
Jul 26, 2023
* polkadot: update weights * westend: update weights * kusama: update weights * rococo: update weights
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B1-note_worthy
Changes should be noted in the release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
T1-runtime
This PR/Issue is related to the topic “runtime”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7149 on release branch