Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix log targets for nonfungibles-adapter #7154

Merged
merged 3 commits into from
May 2, 2023
Merged

fix log targets for nonfungibles-adapter #7154

merged 3 commits into from
May 2, 2023

Conversation

vstam1
Copy link
Contributor

@vstam1 vstam1 commented May 1, 2023

No description provided.

@vstam1 vstam1 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. A0-please_review Pull request needs code review. and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels May 1, 2023
mrcnski
mrcnski approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should it match the name of the file, i.e. xcm::nonfungibles_adapter (no first underscore)? Otherwise someone may try something like RUST_LOG=xcm::nonfungibles_adapter=trace and nothing would show up.

bkchr
bkchr reviewed May 1, 2023
View reviewed changes
xcm/xcm-builder/src/nonfungibles_adapter.rs Outdated
@@ -42,7 +42,7 @@ impl<
context: &XcmContext,
) -> result::Result<xcm_executor::Assets, XcmError> {
log::trace!(
target: "xcm::non_fungibles_adapter",
target: "xcm::nonfungibles_adapter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a constant LOG_TARGET: &str = "xcm::nonfungibles_adapter" instead of copying thus here all the time.

@vstam1
Copy link
Contributor Author

vstam1 commented May 2, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 08f881e into master May 2, 2023
@paritytech-processbot paritytech-processbot bot deleted the vstam1/nonfungibles-adapter-log-bug branch May 2, 2023 14:22
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr left review comments

@liamaharon liamaharon liamaharon approved these changes

@mrcnski mrcnski mrcnski approved these changes

@KiChjang KiChjang KiChjang approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vstam1 @sam0x17 @KiChjang @bkchr @mrcnski @liamaharon