Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Sort migrations by release #7168

Merged
merged 5 commits into from
May 3, 2023
Merged

Sort migrations by release #7168

merged 5 commits into from
May 3, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented May 3, 2023

Sorting them by release should make it easier to backport migrations and ensure that all are included.

@ggwpez
Sort migrations by release
70b9121 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 3, 2023
@paritytech-ci paritytech-ci requested review from a team May 3, 2023 11:16
@ggwpez ggwpez requested a review from chevdor May 3, 2023 11:16
ordian
ordian approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

chevdor
chevdor reviewed May 3, 2023
View reviewed changes
runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved
chevdor
chevdor reviewed May 3, 2023
View reviewed changes
runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved
ggwpez added 4 commits May 3, 2023 15:56
@ggwpez
Inline 'SinceV0940'
6ca4918 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Mention order
098d1b2 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Extend comment
d416f9d 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix compile
04625bd 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
chevdor
chevdor approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ggwpez
Copy link
Member Author

ggwpez commented May 3, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit b9d192c into master May 3, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-sort-migrations-by-release branch May 3, 2023 15:37
@PierreBesson PierreBesson mentioned this pull request May 8, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@chevdor chevdor mentioned this pull request Oct 25, 2023
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@ordian ordian ordian approved these changes

@chevdor chevdor chevdor approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggwpez @chevdor @ordian @bkchr