This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow dbg! macro in tests
#7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a deny(clippy::dbg_macro) in the crate root, so newer Clippy fails here since tests use dbg. But dbg in tests are fine IMHO. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A2-insubstantial
bkchr
approved these changes
May 8, 2023
sandreim
approved these changes
May 8, 2023
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for the monorepo:
There is a
deny(clippy::dbg_macro)in the crate root, so the Clippy fails over there since tests usedbg!.But
dbg!in tests is fine IMHO.I cannot reproduce it locally, even on the the same version though 🤷♂️
cc @alvicsam