This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Stop weighing XCM execution on pallet-xcm's send extrinsic #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoaguirre
added
A0-please_review
KiChjang
approved these changes
May 8, 2023
vstam1
approved these changes
May 9, 2023
KiChjang
suggested changes
May 9, 2023
KiChjang
approved these changes
May 9, 2023
|
Hey @franciscoaguirre I'm guessing this will be included in |
|
I don't see the PR included in |
crystalin
pushed a commit
to moonbeam-foundation/polkadot
that referenced
this pull request
May 23, 2023
…h#7201) * Stop weighing XCM execution on pallet-xcm's send extrinsic * Add missing instruction to transfer extrinsics' weight in pallet-xcm
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the
sendextrinsic onpallet-xcm, we are currently weighing message execution and then adding the weight from benchmarking the extrinsic. We shouldn't do this since we are not executing the message locally. ABuyExecutioninstruction will do that job on the destination of the message. We just need to weigh sending the message.Fixes #7182.