Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Transition to VM weights #7342

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Transition to VM weights #7342

merged 5 commits into from
Jun 21, 2023

Conversation

mateo-moon
Copy link
Contributor

  • Update weights using VM instances.
  • Change runner tag for weights ci job to weights-vm

cc: paritytech/ci_cd#697

@mateo-moon mateo-moon added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jun 8, 2023
@mateo-moon mateo-moon requested a review from a team as a code owner June 8, 2023 10:30
@mateo-moon mateo-moon self-assigned this Jun 8, 2023
@mateo-moon mateo-moon requested a review from chevdor as a code owner June 8, 2023 10:30
@paritytech-ci paritytech-ci requested a review from a team June 8, 2023 10:30
@paritytech-ci paritytech-ci requested a review from a team June 8, 2023 10:34
@paritytech paritytech deleted a comment from command-bot bot Jun 12, 2023
@mateo-moon mateo-moon force-pushed the oleg/ci-cd/weights-vm branch from de6514c to 10357cc Compare June 13, 2023 13:38
@mateo-moon mateo-moon closed this Jun 13, 2023
@mateo-moon mateo-moon force-pushed the oleg/ci-cd/weights-vm branch from 541d680 to b6b74fd Compare June 13, 2023 15:03
@ggwpez
Copy link
Member

ggwpez commented Jun 13, 2023

You force pushed the master commit. That unfortunately breaks the MR.

@mateo-moon
Copy link
Contributor Author

You force pushed the master commit. That unfortunately breaks the MR.

I had to reset to master commit, because there are merging conflicts. I didn't see another option else than start everything again after force rebase of master(

@mateo-moon mateo-moon reopened this Jun 14, 2023
@mateo-moon mateo-moon closed this Jun 14, 2023
@mateo-moon mateo-moon force-pushed the oleg/ci-cd/weights-vm branch from 1649b2c to 59072a3 Compare June 14, 2023 09:15
@command-bot command-bot bot deleted a comment from paritytech-processbot bot Jun 14, 2023
@paritytech paritytech deleted a comment from command-bot bot Jun 14, 2023
@paritytech paritytech deleted a comment from paritytech-processbot bot Jun 14, 2023
@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all polkadot

@command-bot
Copy link

command-bot bot commented Jun 14, 2023

@oleg-plakida Command was rescheduled and failed to finish (check for task id 5-29cd68cf-07a8-4f86-ad75-1207b01b684c in the logs); execution will not automatically be restarted further.

@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all kusama

@command-bot
Copy link

command-bot bot commented Jun 14, 2023

@oleg-plakida Command was rescheduled and failed to finish (check for task id 6-f1f17758-7251-4252-b319-c3cdfdb294c7 in the logs); execution will not automatically be restarted further.

@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all rococo

@command-bot
Copy link

command-bot bot commented Jun 14, 2023

@oleg-plakida Command was rescheduled and failed to finish (check for task id 7-c59a88da-61ed-49b9-ae30-f42cdc1ef1f8 in the logs); execution will not automatically be restarted further.

@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all westend

@command-bot
Copy link

command-bot bot commented Jun 14, 2023

@oleg-plakida Command was rescheduled and failed to finish (check for task id 8-00dfdb82-ca12-4224-ab24-233e84334ee1 in the logs); execution will not automatically be restarted further.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3004757 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all polkadot. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-7430ca96-6e00-4ed2-b8f8-0fa3f1a3f6c9 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all polkadot has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3004757 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3004757/artifacts/download.

@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all polkadot

@command-bot
Copy link

command-bot bot commented Jun 15, 2023

@oleg-plakida Command was rescheduled and failed to finish (check for task id 3-d5406ae1-61a8-4c84-98fd-2163648232b5 in the logs); execution will not automatically be restarted further.

@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all polkadot

@command-bot
Copy link

command-bot bot commented Jun 18, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3017945 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all polkadot. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-d1783493-1257-4253-aa87-8fe838b12378 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all polkadot has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3017945 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3017945/artifacts/download.

@mateo-moon mateo-moon reopened this Jun 19, 2023
@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all kusama

@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3022130 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all kusama. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-30221952-f80f-40b6-8d43-b3aa6086493c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 19, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all kusama has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3022130 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3022130/artifacts/download.

@mateo-moon
Copy link
Contributor Author

bot bench-vm $ all rococo

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@oleg-plakida https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3030458 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all rococo. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-83656975-32cb-4950-9b95-9a9344c69946 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jun 20, 2023

@oleg-plakida Command "$PIPELINE_SCRIPTS_DIR/commands/bench-vm/bench-vm.sh" all rococo has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3030458 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3030458/artifacts/download.

Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez
Copy link
Member

ggwpez commented Jun 21, 2023

That leads to a few major increases, which is fine as long as it is consistent.

Looking at asymptotic makes a bit more sense for the ones that do not have a proper base component, but having a few out of ~1670 benchmarks off is fine i think.
Just need to monitor that they stay consistent after this is merged.

@@ -0,0 +1,154 @@
// Copyright (C) Parity Technologies (UK) Ltd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we are not using the correct weight file for Kusama follow up for https://github.com/paritytech/polkadot/issues/7408

@mateo-moon mateo-moon merged commit eee4ea3 into master Jun 21, 2023
@mateo-moon mateo-moon deleted the oleg/ci-cd/weights-vm branch June 21, 2023 13:01
@mateo-moon mateo-moon restored the oleg/ci-cd/weights-vm branch June 21, 2023 13:04
@mateo-moon mateo-moon deleted the oleg/ci-cd/weights-vm branch June 21, 2023 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants