Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Increase recusive limits for macro expansions #7401

Closed
wants to merge 14 commits into from

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Jun 20, 2023

Companion of paritytech/substrate#14143

@paritytech/subxt-team

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jun 20, 2023
@lexnv lexnv self-assigned this Jun 20, 2023
@paritytech-ci paritytech-ci requested review from a team June 20, 2023 10:12
@ggwpez ggwpez added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jun 20, 2023
@paritytech-ci paritytech-ci requested a review from a team June 20, 2023 11:46
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv changed the title Increase recusive limit to 512 for macro expansions Increase recusive limit to 1024 for macro expansions Jun 20, 2023
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv changed the title Increase recusive limit to 1024 for macro expansions Increase recusive limits for macro expansions Jun 20, 2023
@lexnv
Copy link
Contributor Author

lexnv commented Jun 21, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@lexnv
Copy link
Contributor Author

lexnv commented Jun 27, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 76ada8b

@lexnv
Copy link
Contributor Author

lexnv commented Jun 28, 2023

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

ggwpez added 2 commits June 28, 2023 13:01
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@lexnv
Copy link
Contributor Author

lexnv commented Jun 28, 2023

Have cherry-picked the patches from #7433, this will hopefully pass the CI and unblock further work.

Soon these merge conflict races will be solved by the mono-repo work

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3085382

ggwpez added 2 commits June 28, 2023 12:59
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr
Copy link
Member

bkchr commented Jun 28, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@bkchr
Copy link
Member

bkchr commented Jun 28, 2023

Included in: #7433

@bkchr bkchr closed this Jun 28, 2023
@bkchr bkchr deleted the lexnv/metadata_outer_enums branch June 28, 2023 11:34
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for c2780c4

@lexnv
Copy link
Contributor Author

lexnv commented Jun 28, 2023

Thanks a lot @bkchr and @ggwpez for the help here!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants