This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
ci: always run runtime migration checks #7422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
added
A0-please_review
liamaharon
added
A3-in_progress
liamaharon
added
A0-please_review
alvicsam
previously requested changes
Jun 26, 2023
altaua
approved these changes
Jun 26, 2023
9 tasks
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
ggwpez
reviewed
Jun 27, 2023
…itytech/polkadot into liam-always-run-runtime-migration-ci
…ays-run-runtime-migration-ci
ggwpez
reviewed
Jun 29, 2023
coderobe
approved these changes
Jun 29, 2023
alvicsam
approved these changes
Jun 30, 2023
2 tasks
|
The rococo wont turn green before .43 is applied, or? |
|
bot merge |
paritytech-processbot
bot
deleted the
liam-always-run-runtime-migration-ci
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime migration checks are much more stable now, FRAME team would like to get to a point where they are non-optional on every PR.
We can start by running the checks on every PR, and once paritytech/substrate#14311 is merged and we fix some recently introduced issues get them all green.
Once they've been green for a while and we're confident in their stability we can disable
allow_failure.blocked by