This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update pr-custom-review.yml 3 Core-devs to approve #7453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorPopelyaev
approved these changes
Jul 3, 2023
coderobe
approved these changes
Jul 3, 2023
alvicsam
approved these changes
Jul 3, 2023
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Until last week we always had to have minimum 2 approvals from core-devs to merge PR, regardless if you're core-dev or external contributor
Due to paritytech/pr-custom-review#104 we've started count the contributor (PR author) as one of the "knower-of-code", so now, if we keep
min_approvals: 2, for core-dev author PRs - it's only 1 approval needed to merge, (example #7451), thus we need to bump min_approvals to match a criteria in paritytech/pr-custom-review#104Read more:
After this change, core-dev authors will remain to have 2 reviews to be made by other core-devs,
while external developers would require 3 core-dev approvals