Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[DNM] Feature/merge no gossip of approvals with assignments v2 #7522

Closed
wants to merge 110 commits into from
Closed

[DNM] Feature/merge no gossip of approvals with assignments v2 #7522

wants to merge 110 commits into from

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented Jul 19, 2023

Ignore, not intended for review.

This is just a merge implementation of #6782 with #7482 to generate a docker image for testing in versi.

@sandreim
Add compact vrf modulo assignment
4adfc1f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
compute all assignments from a single vrf output
71bf07b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
impl compute/check of RelayVRFModuloCompact
b1aabc9 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fmt and missed file
8b881ee 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
check_and_import_assignment: multiple candidates
81e62ec 
- tuned test params to test single and multiple assignments

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
integration step 1: subsystem message changes
82c2b5f 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Approval distribution WIP
d9d5681 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
approval-dist: fixed compilation errors
596a347 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
test fixups, WIP
c87502b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
itertools
cc9f63a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Allow claimed cores to be a subset of vrf output assignments
eb86e56 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Revert approval distribution changes
4d421d2 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
WIP
7b6db76 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Fix compile errors
46d76d4 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
add todo
b18295e 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Keep track of peer protocol version
a41254c 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
network protocol bump and addition
3bb8823 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Approval distribution handing of v1 vs v2
b34788e 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Add VStaging network protocol
48109ec 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
comment aggression metrics
b672d86 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
finish impl v2/v1 sending
2a300de 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix view change handling typo bug
7858ad5 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Rename leftover V2 to vstaging
0cf73fd 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Disable assignments V2
412282a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
update todo, docs
af3b64b 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fmt
6612b3c 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Temporarly disable CI cargo test to get a build for burn-in
f8ccec9 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
debug -> trace
ef42e0c 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
enable v2 assignments
0c31d61 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Remove unimplemented!
e3598b1 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
sandreim and others added 27 commits June 12, 2023 09:26
@sandreim
Implement seq updates 0->4 now possible for parachainsDB
112b0be 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
add/fix db upgrade tests
4b1743c 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
36f6b39 
…/vrf_modulo_comapct_assignment
@pepoviola
update colander image version
4e0fac6
@pepoviola
update image to polkadot-parachain
7f97355
@sandreim
review
d356081 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fmt
a179646 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Remove superfuous assignment_bitfield from OurAssignment
de6ea33 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@alexggh
node: approval-distribution/voting: lazy approvals signature checks
bbcf35d 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
fix warning in test-linux-stable
1245d18 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Hack: Disable gossiping at a certain block number
e28153f 
... to ease up quick testing in versi

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
HACK: Add versi block to start test
7f9a314 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Hack: update versi enablement block number
db7a840 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Fix
f0a2472 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Test block time
9ebee8c 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Fixed on delayed approval processed
69b7e8e 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Add more metrics regarding gossipped approvals
f24fc2f 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Add metric as well
1c312ed 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Add more logs to understand why gossiping is still happening
953bc16 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
add more metrics: to understand versi behaviour
5f6edef 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
fix: gossiped approvals received metric
b09a619 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Add more logs to debug metrics
2af3525 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
2af7d29 
…gnment' into newer master
@alexggh
Merge branch 'assignment_v2' into approval_voting_lazy_checking_assig…
5a4cec9 
…nment_v2
@alexggh
Adapt no gossip approval for assignments v2
6ae7d1c 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Fix tests warnings
e2358d0 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Enable assignments v2
47212a8 
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3228596

@alexggh
Copy link
Contributor Author

alexggh commented Jul 25, 2023

On hold in favor of: paritytech/polkadot-sdk#701

@alexggh alexggh closed this Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexggh @paritytech-cicd-pr @sandreim @pepoviola