Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Overcharging on limited_teleport_assets #7528

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Overcharging on limited_teleport_assets #7528

merged 1 commit into from
Jul 24, 2023

Conversation

gilescope
Copy link
Contributor

We count the teleported assets these days ( #6980 ) in the underlying do_teleport_assets function:

polkadot/xcm/pallet-xcm/src/lib.rs

Line 1304 in e0ed7e8

InitiateTeleport { assets: Wild(AllCounted(max_assets)), dest, xcm },

so we should use AllCounted rather than All for calculating the weight as we already do with the teleport_assets function's weight here:

polkadot/xcm/pallet-xcm/src/lib.rs

Line 820 in e0ed7e8

assets: Wild(AllCounted(count)),

@gilescope
We count the teleported assets
3899a45 
This brings the `limited_teleport_assets` weight into line with the
`teleport_assets` weight.
@gilescope gilescope added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. B1-note_worthy Changes should be noted in the release notes labels Jul 20, 2023
@gilescope gilescope added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jul 20, 2023
@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 4776230 into master Jul 24, 2023
13 of 18 checks passed
@paritytech-processbot paritytech-processbot bot deleted the giles-limited-teleport-assets-weight-overcharged branch July 24, 2023 08:42
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@bkontur bkontur bkontur approved these changes

@NachoPal NachoPal NachoPal approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilescope @KiChjang @bkontur @NachoPal