Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

cli: remove deprecated try-runtime subcommand (also companion for #14731) #7599

Merged
merged 12 commits into from
Aug 17, 2023
Merged

cli: remove deprecated try-runtime subcommand (also companion for #14731) #7599

merged 12 commits into from
Aug 17, 2023

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Aug 11, 2023 •
edited
Loading

Companion for paritytech/substrate#14731

try-runtime subcommand is being deprecated.

This PR replaces the subcommand with a stub/deprecation notice which includes instructions on how to use the standalone CLI.

TODO before merge

@liamaharon liamaharon added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C3-medium PR touches the given topic and has a medium impact on builders. B1-note_worthy Changes should be noted in the release notes labels Aug 11, 2023
@liamaharon liamaharon marked this pull request as draft August 11, 2023 05:30
@liamaharon liamaharon mentioned this pull request Aug 11, 2023
Merged
1 task
@liamaharon liamaharon marked this pull request as ready for review August 11, 2023 10:51
@liamaharon liamaharon requested review from chevdor and a team as code owners August 11, 2023 10:51
@paritytech-ci paritytech-ci requested a review from a team August 11, 2023 10:51
@liamaharon liamaharon changed the title cli: remove deprecated try-runtime subcommand Companion for #14731 Aug 11, 2023
@liamaharon liamaharon changed the title Companion for #14731 cli: remove deprecated try-runtime subcommand (also companion for #14731) Aug 11, 2023
@liamaharon liamaharon added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C3-medium PR touches the given topic and has a medium impact on builders. labels Aug 11, 2023
@liamaharon liamaharon added the T0-node This PR/Issue is related to the topic “node”. label Aug 14, 2023
@liamaharon liamaharon requested a review from ggwpez August 16, 2023 07:57
@paritytech-ci paritytech-ci requested a review from a team August 16, 2023 08:30
alvicsam
alvicsam suggested changes Aug 16, 2023
View reviewed changes
scripts/ci/gitlab/pipeline/check.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team August 16, 2023 08:58
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit d74c60b into master Aug 17, 2023
@paritytech-processbot paritytech-processbot bot deleted the liam-deprecate-try-runtime-cli branch August 17, 2023 05:57
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergejparity sergejparity sergejparity approved these changes

@alvicsam alvicsam alvicsam approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@chevdor chevdor Awaiting requested review from chevdor

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liamaharon @sam0x17 @EgorPopelyaev @ggwpez @alvicsam @sergejparity