-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added local caching mechanism for list of polkadot-sdk versions to fasten fetch time #28
base: main
Are you sure you want to change the base?
Conversation
File cache implementation for locally caching available versions of polkadot-sdk
…/github.com/paritytech/psvm to include CI/CD changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please not. This tool is very simple. We should keep it simple and only exactly as complicated as necessary.
I dont see any reason to add caching. Projects will use this maybe once per month - most. There is no way we need a cache in this. It this tool was often used, or somehow time critical then i would say yes, but not for this.
This tool has to stay very simple, since it only shows a miss design in how we currently handle releases. It is meant as intermediate solution and nothing that we should try to massively extend. There is no gain from this.
If you want to make a CLI faster, i would suggest https://github.com/paritytech/try-runtime-cli, it runs in CI on every pull request and is currently using CI cached files. It takes about 15 min or more to create a snapshot, but is also difficult to optimize. Anyway, any effort spent here should rather go to a more value bearing project.
Oh alright got it. Sorry I thought it would be helpful. Thanks! |
Sure I will give it a look! Thank you so much! |
This PR introduces a
--cache
flag to locally store the list of polkadot-sdk versions to exponentially fasten their fetch time compared to the GitHub API or CLI. A--update-cache
flag is also added to just update the local cache by freshly fetching the available versions from GitHub.Key Features: