Skip to content

Commit

Permalink
updated github actions to use latest major version (#128)
Browse files Browse the repository at this point in the history
This solves the problem that actions/cache was not working and removes
all the warnings.
  • Loading branch information
Bullrich authored Jul 3, 2024
1 parent 04d633e commit 4d1f40d
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/github-issue-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- name: Generate token
id: generate_token
uses: actions/create-github-app-token@v1.9.3
uses: actions/create-github-app-token@v1
with:
app-id: ${{ secrets.PROJECT_APP_ID }}
private-key: ${{ secrets.PROJECT_APP_KEY }}
Expand Down
23 changes: 12 additions & 11 deletions .github/workflows/javascript-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,21 @@ jobs:
name: running ${{ matrix.command }}
timeout-minutes: 5
steps:
- uses: actions/checkout@v4.1.3
- uses: actions/setup-node@v4.0.2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT
- name: Cache node modules
id: cache-npm
uses: actions/cache@v4.0.2
env:
cache-name: cache-node-modules
id: yarn-cache
uses: actions/cache@v4
with:
# npm cache files are stored in `~/.npm` on Linux/macOS
path: ~/.npm
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
restore-keys: ${{ runner.os }}-build-${{ env.cache-name }}-
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
- name: Install dependencies
run: yarn install --immutable
- run: yarn run ${{ matrix.command }}
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ jobs:
test-image:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4.1.3
- uses: actions/checkout@v4
- name: Check that the image builds
run: docker build . --file Dockerfile
validate-action:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v4.1.3
- uses: actions/checkout@v4
# This checks that .github/workflows/review-bot.yml is pointing towards the main branch
# as, during development, we change this to use the code from the test branch and
# we may forget to set it back to main
Expand All @@ -43,7 +43,7 @@ jobs:
version: ${{ steps.verification.outputs.VERSION }}
exists: ${{ steps.checkTag.outputs.exists }}
steps:
- uses: actions/checkout@v4.1.3
- uses: actions/checkout@v4
- name: Extract package.json version
id: package_version
run: echo "VERSION=$(jq '.version' -r package.json)" >> $GITHUB_OUTPUT
Expand All @@ -68,14 +68,14 @@ jobs:
contents: write
packages: write
steps:
- uses: actions/checkout@v4.1.3
- uses: actions/checkout@v4
- name: Tag version and create release
run: gh release create $VERSION --generate-notes
env:
VERSION: v${{ needs.compare-versions.outputs.version }}
GH_TOKEN: ${{ github.token }}
- name: Log in to the Container registry
uses: docker/login-action@v3.1.0
uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
Expand All @@ -86,9 +86,9 @@ jobs:
with:
images: ${{ env.REGISTRY }}/${{ github.repository }}/${{ env.IMAGE_NAME }}
tags: ${{ needs.compare-versions.outputs.version }}
- uses: actions/checkout@v4.1.3
- uses: actions/checkout@v4
- name: Build and push Docker image
uses: docker/build-push-action@v5.3.0
uses: docker/build-push-action@v5
with:
context: .
push: true
Expand Down

0 comments on commit 4d1f40d

Please sign in to comment.