Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added output to action execution #50

Merged
merged 5 commits into from
Aug 16, 2023
Merged

added output to action execution #50

merged 5 commits into from
Aug 16, 2023

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Aug 16, 2023

Added an output to the action.

It will return a stringified JSON of type:

type PullRequestReport = {
  /** List of files that were modified by the PR */
  files: string[];
  /** List of all the failed review requirements */
  reports: {
    /** The amount of missing reviews to fulfill the requirements */
    missingReviews: number;
    /** The users who would qualify to complete those reviews */
    missingUsers: string[];
    /** If applicable, the teams that should be requested to review */
    teamsToRequest?: string[];
    /** If applicable, the users that should be requested to review */
    usersToRequest?: string[];
  }[];
};

Resolves #17 and resolves #43

@Bullrich Bullrich linked an issue Aug 16, 2023 that may be closed by this pull request
@Bullrich Bullrich marked this pull request as ready for review August 16, 2023 13:49
@Bullrich Bullrich requested a review from a team as a code owner August 16, 2023 13:49
Copy link
Contributor

@mordamax mordamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Bullrich Bullrich enabled auto-merge (squash) August 16, 2023 15:03
This reverts commit d40dcfa.
@Bullrich Bullrich merged commit 13b897c into main Aug 16, 2023
@Bullrich Bullrich deleted the generate-output branch August 16, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate output
3 participants