Integrate fellowship-process-bot
#10
Conversation
Co-authored-by: Bryan Chen <xlchen1291@gmail.com>
| errorMessage: `Unable to find the referendum confirm event in the given block.\n\n` + blockHashInstructions, | ||
| }; | ||
| } | ||
| if ("approved" in referendum && referendum.approved) { |
There was a problem hiding this comment.
if we've created an RFC and the hash of .md file is X, but then until it's approved and processed, the hash has been changed (someone pushed some update to file) - then we should check if before merge? and either propose to create a new referendum with a new file hash or roll back to an approved commit, right?
There was a problem hiding this comment.
If some pushes some update and the hash changes, then the referendum will not be found by the action.
It will respond back with a "Unable to find the referendum" message and the PR will not be merged.
There was a problem hiding this comment.
ah that makes sense!
if someone pushes the updates to file during ongoing referendum should we do something with it or suggest some actions?
There was a problem hiding this comment.
Hmm, we would have to check every commit on the PR branch, and if we find one that matches a referendum, that means we detected this situation and can suggest actions (e.g. suggest to roll-back to that commit).
I have created a separate issue for this: #11
| ``` | ||
|
|
||
| If you're not sure where to get this block hash, | ||
| send a `/rfc process` command and the action will respond with more instructions. |
There was a problem hiding this comment.
how do people learn about existing commands within repo and its interface?
does it make sense to output this when someone types /rfc or /rfc help or they can head here to README from somewhere else?
There was a problem hiding this comment.
We have this little thing responding to /rfc: paritytech-stg/RFCs#9 (comment)
I'll add something for the /rfc help prompt.
This PR integrates the functionality of the fellowship-process-bot action into this repo.
The functionality is to merge (or close) a PR depending on the on-chain referendum.
rfc-proposetorfc-action/rfc propose, which is the existing functionality of proposing a referendum/rfc process, which processes the on-chain referendum and merges/closes the PR.Co-authored-by: Bryan Chen xlchen1291@gmail.com