cron: Added comment for completed RFCs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bullrich
force-pushed
the
cron/close-completed-rfcs-prs
branch
from
2655eaa
to
982d416
Compare
mordamax
reviewed
Feb 28, 2024
This way, we don't execute it once it was already executed
Now it also fetches completed RFCs from an older date
rzadp
reviewed
Feb 29, 2024
rzadp
reviewed
Feb 29, 2024
rzadp
reviewed
Feb 29, 2024
rzadp
reviewed
Feb 29, 2024
# Conflicts: # dist/index.js
And added logging of queries which are not handled
This way the tests don't depend on it
|
Hi @rzadp! Thank you for your thorough review! You had a lot of great points! I have addressed all of them. I also rewrite a bit the subsquare logic which should now make it more straightforward (and fixed the issue with the tests using an api) |
rzadp
approved these changes
Feb 29, 2024
Bullrich
added a commit
to Bullrich/polkadot-fellows-rfcs
that referenced
this pull request
Feb 29, 2024
This includes paritytech/rfc-action#34 which takes into consideration successful RFCs. When a RFC closed after the last run, it will comment on the open PR (if it is still open) that the RFC has been closed and how to trigger the bot to merge the PR. If it is succesfull, we can automate it to simply close the PRs without human input.
bkchr
pushed a commit
to polkadot-fellows/RFCs
that referenced
this pull request
Mar 4, 2024
This includes paritytech/rfc-action#34 which takes into consideration successful RFCs. When a RFC closed after the last run, it will comment on the open PR (if it is still open) that the RFC has been closed and how to trigger the bot to merge the PR. If it is succesfull, we can automate it to simply close the PRs without human input. Also, updated actions/create-github-app-token to latest (version `1.8.1`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to check on open PRs if they match with a completed referenda.
If it matches, it will comment on it for the system to close it using the latest block from the timeline
Summary
SubsquareApiclass for fetching referenda data.