Prepare release with SCALE 3.0 #140
Conversation
Cargo.toml
Outdated
| @@ -16,10 +16,10 @@ include = ["Cargo.toml", "src/**/*.rs", "README.md", "LICENSE"] | |||
| [dependencies] | |||
| bitvec = { version = "0.20.1", default-features = false, features = ["alloc"], optional = true } | |||
| cfg-if = "1.0" | |||
| scale-info-derive = { version = "1.0.0", path = "derive", default-features = false, optional = true } | |||
| scale-info-derive = { version = "1.0.1", path = "derive", default-features = false, optional = true } | |||
There was a problem hiding this comment.
We may have to make this 2.0 since the major bump of the requirement for parity-scale-codec makes it a breaking change.
There was a problem hiding this comment.
Scale 3 is also edition 2021 with an increased minimum Rust version, so I completely agree there.
There was a problem hiding this comment.
I seem to be unable to formulate a rule about how to deal with dependency updates, how a breaking change downstream translates. It seems to be a common problem. Then there's the matter of MSRV, which I don't think we're taking into consideration at all here.
There was a problem hiding this comment.
There is no real consensus in the Rust community either. With a complex project like Substrate, I would err on too much safety and more manual upgrades, and implement some helper tools to make the overview of outdated deps easier.
wigy-opensource-developer
changed the title
|
@wigy-opensource-developer #137 is merged now, so we can pull that in here and set the version to 2.0. |
|
Jinx. Did a |
|
Hehe, sorry! |
No description provided.