-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Rc TypeInfo ✨ #185
Conversation
hey @niklasad1 want me to bump the version before merging ? |
Clippy seems to be complaining for no reasons too EDIT: Why is |
Cargo lock is meaningless in library crates (upstream dependencies will ignore it and generate their own cargo locks instead etc) The clippy errors are possibly just new errors that appeared since rust was updated. The cleanest approach would be another PR that runs a clippy --fix etc to sort these out :) |
Sounds good thanks for the quick answer @jsdw ! |
Oh and no need for any version bumps; that'll be taken care of when we do a release :) |
Thanks I do have something weird happening in my project tho : You can checkout this PR to see |
I haven't checked, but I'm guessing it's because there are now multiple versions of scale-info in your cargo tree; use the cargo.toml patch stuff if you aren't already to ensure all scale-infos use your fork :) |
Great! Could we merge this ? @jsdw or anything blocking let me know |
This still needs fixing; I'll open a new PR to address those and then when this branch is updated and passing we can merge it! |
Edit: nevermind; re-ran the job and it passed! |
I have a merkle tree implementation that uses Rc and I want to store that within my substrate runtime but it's not possible so let make it happen!