Introduce SecretStore for Substrate binary #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
commented
Mar 17, 2020
| )?, | ||
| ).await.map_err(|error| format!("Failed to start substrate client: {:?}", error))?; | ||
|
|
||
| // TODO: use db key storage |
There was a problem hiding this comment.
This is a next thing to fix - I'm preparing a PR that will reintroduce persistent keys storage and then will make a PR that fixes this TODO.
grbIzl
approved these changes
Mar 17, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces first SS binary in this repo:
parity-secretstore-substrate. It starts key server, substrate service and connects to Substrate node that run blockchain with SecretStore module. Since there could be multiple different blockchains which use different hashes, transactions, etc, this binary is designed to be 'generic' (not as in Rust) over runtime. Everything must be configured in theruntime.rsmodule. The node should also exposesystem_accountNextIndexRPC. Right now it is configured to work with thebin/substrate-node.Tests are yet to be added - both integration (#17 ) and module-level.