Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

Jesse removal miss block #45

Merged
merged 19 commits into from
May 5, 2021
Merged

Jesse removal miss block #45

merged 19 commits into from
May 5, 2021

Conversation

JesseAbram
Copy link
Contributor

No description provided.

@JesseAbram JesseAbram requested a review from joepetrowski April 26, 2021 10:45
@JesseAbram JesseAbram marked this pull request as ready for review April 26, 2021 10:46
@JesseAbram JesseAbram requested a review from kianenigma April 29, 2021 12:06
kianenigma
kianenigma reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some comments, but mostly looks good.

pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
runtime/statemine/src/lib.rs Show resolved Hide resolved
pallets/collator-selection/src/tests.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/tests.rs Outdated Show resolved Hide resolved
JesseAbram and others added 4 commits April 30, 2021 10:06
@JesseAbram @kianenigma
Update pallets/collator-selection/src/lib.rs
086fdf6 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@JesseAbram @kianenigma
Update pallets/collator-selection/src/lib.rs
0ba2517 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@JesseAbram
tweaks
4e5512b
@JesseAbram
returned candidates length
b8ae457
kianenigma
kianenigma reviewed May 3, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a good track, but I have some further comments 🙈

pallets/collator-selection/src/lib.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/tests.rs Outdated Show resolved Hide resolved
pallets/collator-selection/src/benchmarking.rs Outdated Show resolved Hide resolved
kianenigma
kianenigma approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have done some details a bit differently, but looks correct 👍

@JesseAbram @kianenigma
Update pallets/collator-selection/src/lib.rs
3a77d11 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@JesseAbram JesseAbram merged commit d79ce79 into master May 5, 2021
@JesseAbram JesseAbram deleted the jesse-removal-miss-block branch May 5, 2021 16:40
@kianenigma kianenigma mentioned this pull request May 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr left review comments

@kianenigma kianenigma kianenigma approved these changes

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

Assignees
No one assigned
Labels
A3-inprogress A6-mustntgrumble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesseAbram @kianenigma @bkchr