Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section about brave browser web socket setting #1186

Merged
merged 6 commits into from
Aug 8, 2022

Conversation

wirednkod
Copy link
Contributor

Closes #1179

@wirednkod wirednkod requested a review from tomaka August 5, 2022 13:33
@tomaka
Copy link
Contributor

tomaka commented Aug 8, 2022

What's the difference with #1180 ?

@wirednkod
Copy link
Contributor Author

What's the difference with #1180 ?

This PR adds an informative section about Brave websockets in the Landing page. #1180 has the impl of the modal in the extension's popup and options page.

projects/landing-page/src/App.tsx Outdated Show resolved Hide resolved
projects/landing-page/src/App.tsx Outdated Show resolved Hide resolved
projects/landing-page/src/App.tsx Outdated Show resolved Hide resolved
projects/landing-page/src/App.tsx Outdated Show resolved Hide resolved
wirednkod and others added 4 commits August 8, 2022 11:49
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
@wirednkod wirednkod added the automerge Instructs Mergify to queue this pull request for automatic merging label Aug 8, 2022
@mergify mergify bot merged commit d9e7c95 into main Aug 8, 2022
@mergify mergify bot deleted the nik-add-brave-section-to-landing-page branch August 8, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Instructs Mergify to queue this pull request for automatic merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Section concerning Restrict WebSockets pool on Brave Browser
2 participants