-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension logging #853
Extension logging #853
Conversation
…ate-connect into nik-keep-logs-extension
Logs only make sense if they're in the correct context. |
In |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good!
…k-keep-logs-extension
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
…ate-connect into nik-keep-logs-extension
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
This PR covers all-but-one (the last) bullets of Pierre's comment in issue #429 .
Some details
I left the
info
logs to still appear in the console. 1000 lines are kept in memory and shown in the extension's Option page.The
semi-hidden
way for now is another tab in the Options page. This will be adjusted in the next UI upgrade from @Goranch32 placeholders are keeping separate from rotating debug logs, the errors and warnings. Even though only 1000 latest lines are are kept from debug logs and then older ones are dissappearing, warning and errors are kept.
Last bullet of Pierre's comment will be addressed in different PR.
A screenshot on the UI perspective can be seen below: