Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Commit

Permalink
Enrich the sync log on handling the block request (#11747)
Browse files Browse the repository at this point in the history
Add more info to the log to help debug the issue like
https://github.com/paritytech/substrate/issues/11732.

Co-authored-by: Bastian Köcher <info@kchr.de>
  • Loading branch information
liuchengxu and bkchr authored Jul 28, 2022
1 parent 782e08e commit b8591d6
Showing 1 changed file with 19 additions and 9 deletions.
28 changes: 19 additions & 9 deletions client/network/sync/src/block_request_handler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -226,16 +226,13 @@ where

debug!(
target: LOG_TARGET,
"Handling block request from {}: Starting at `{:?}` with maximum blocks \
of `{}`, direction `{:?}` and attributes `{:?}`.",
peer,
from_block_id,
max_blocks,
direction,
attributes,
"Handling block request from {peer}: Starting at `{from_block_id:?}` with \
maximum blocks of `{max_blocks}`, reputation_change: `{reputation_change:?}`, \
small_request `{small_request:?}`, direction `{direction:?}` and \
attributes `{attributes:?}`.",
);

let result = if reputation_change.is_none() || small_request {
let maybe_block_response = if reputation_change.is_none() || small_request {
let block_response = self.get_block_response(
attributes,
from_block_id,
Expand All @@ -259,9 +256,22 @@ where
}
}

Some(block_response)
} else {
None
};

debug!(
target: LOG_TARGET,
"Sending result of block request from {peer} starting at `{from_block_id:?}`: \
blocks: {:?}, data: {:?}",
maybe_block_response.as_ref().map(|res| res.blocks.len()),
maybe_block_response.as_ref().map(|res| res.encoded_len()),
);

let result = if let Some(block_response) = maybe_block_response {
let mut data = Vec::with_capacity(block_response.encoded_len());
block_response.encode(&mut data)?;

Ok(data)
} else {
Err(())
Expand Down

0 comments on commit b8591d6

Please sign in to comment.