fixed batch verificaiton tests

removed additional zero verificaiton tests

primitives/io/src/lib.rs

@@ -1575,19 +1575,18 @@ mod tests {
  ext.register_extension(TaskExecutorExt::new(TaskExecutor::new()));
  ext.execute_with(|| {
  let pair = sr25519::Pair::generate_with_phrase(None).0;
+ let pair_unused = sr25519::Pair::generate_with_phrase(None).0;
  crypto::start_batch_verify();
  for it in 0..70 {
  let msg = format!("Schnorrkel {}!", it);
  let signature = pair.sign(msg.as_bytes());
  crypto::sr25519_batch_verify(&signature, msg.as_bytes(), &pair.public());
  }
 
- // push invlaid
- crypto::sr25519_batch_verify(
- &Default::default(),
- &Vec::new(),
- &Default::default(),
- );
+ // push invalid
+ let msg = format!("asdf!");
+ let signature = pair.sign(msg.as_bytes());
+ crypto::sr25519_batch_verify(&signature, msg.as_bytes(), &pair_unused.public());
  assert!(!crypto::finish_batch_verify());
 
  crypto::start_batch_verify();
@@ -1605,15 +1604,6 @@ mod tests {
  let mut ext = BasicExternalities::default();
  ext.register_extension(TaskExecutorExt::new(TaskExecutor::new()));
  ext.execute_with(|| {
- // invalid ed25519 signature
- crypto::start_batch_verify();
- crypto::ed25519_batch_verify(
- &Default::default(),
- &Vec::new(),
- &Default::default(),
- );
- assert!(!crypto::finish_batch_verify());
-
  // 2 valid ed25519 signatures
  crypto::start_batch_verify();
 
@@ -1632,16 +1622,13 @@ mod tests {
  // 1 valid, 1 invalid ed25519 signature
  crypto::start_batch_verify();
 
- let pair = ed25519::Pair::generate_with_phrase(None).0;
+ let pair1 = ed25519::Pair::generate_with_phrase(None).0;
+ let pair2 = ed25519::Pair::generate_with_phrase(None).0;
  let msg = b"Important message";
- let signature = pair.sign(msg);
- crypto::ed25519_batch_verify(&signature, msg, &pair.public());
+ let signature = pair1.sign(msg);
 
- crypto::ed25519_batch_verify(
- &Default::default(),
- &Vec::new(),
- &Default::default(),
- );
+ crypto::ed25519_batch_verify(&signature, msg, &pair1.public());
+ crypto::ed25519_batch_verify(&signature, msg, &pair2.public());
 
  assert!(!crypto::finish_batch_verify());
 
@@ -1668,16 +1655,12 @@ mod tests {
  // 1 valid sr25519, 1 invalid sr25519
  crypto::start_batch_verify();
 
- let pair = sr25519::Pair::generate_with_phrase(None).0;
+ let pair1 = sr25519::Pair::generate_with_phrase(None).0;
+ let pair2 = sr25519::Pair::generate_with_phrase(None).0;
  let msg = b"Schnorrkcel!";
  let signature = pair.sign(msg);
- crypto::sr25519_batch_verify(&signature, msg, &pair.public());
-
- crypto::sr25519_batch_verify(
- &Default::default(),
- &Vec::new(),
- &Default::default(),
- );
+ crypto::sr25519_batch_verify(&signature, msg, &pair1.public());
+ crypto::sr25519_batch_verify(&signature, msg, &pair2.public());
 
  assert!(!crypto::finish_batch_verify());
  });