Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Sweep runtime for panics #668

Closed
gavofyork opened this issue Sep 5, 2018 · 1 comment
Closed

Sweep runtime for panics #668

gavofyork opened this issue Sep 5, 2018 · 1 comment
Assignees
@Demi-Marie
Labels
I2-security The client fails to follow expected, security-sensitive, behaviour.
Milestone
Polkadot

Comments

@gavofyork
Copy link
Member

gavofyork commented Sep 5, 2018 •
edited
Loading

The runtime should not be able to panic except under circumstances that are statically analysable.

Basically, this means once any necessary inherent extrinsics have been determined to be present and valid, and once the transaction extrinsics have been determined to be properly signed and coming from accounts with the correct nonce and that can afford to pay for them, then execute_block MUST NEVER PANIC.
@gavofyork gavofyork added the I2-security The client fails to follow expected, security-sensitive, behaviour. label Sep 5, 2018
@gavofyork gavofyork added this to the 1.0 milestone Sep 5, 2018
@gavofyork gavofyork modified the milestones: 1.1, 1.0 Feb 6, 2019
@gavofyork gavofyork modified the milestones: 1.0, 1.1 Mar 27, 2019
@Demi-Marie
Copy link
Contributor

Can we statically verify this? It seems to me that by making panic_fmt refer to an undefined symbol, we will get a link failure if the compiler cannot prove that the panic code is unreachable.

@sorpaas sorpaas self-assigned this Jun 12, 2019
@sorpaas sorpaas mentioned this issue Jun 14, 2019
Merged
@gavofyork gavofyork assigned Demi-Marie and unassigned sorpaas Nov 28, 2019
@gavofyork gavofyork modified the milestones: 1.1, 3.0 Nov 28, 2019
liuchengxu added a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
@liuchengxu
Add MimimumCandidateThreshold (paritytech#668)
5812b9e 
* Add MimimumCandidateThreshold

Close paritytech#664

* Support both quantity and ratio

* Change TotalBonded and SelfBonded criteria

* Nit

* Update wasm

* Build wasm

* Nit

* Nit

* .

* Use plain tuple for MinimumCandidateThreshold

* Fix tests
@bedeho bedeho mentioned this issue Apr 11, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Demi-Marie Demi-Marie

Labels
I2-security The client fails to follow expected, security-sensitive, behaviour.
Projects
None yet
Milestone
Polkadot
Development

No branches or pull requests
4 participants
@gavofyork @shawntabrizi @sorpaas @Demi-Marie