Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove empty #[pallet::hooks] or #[pallet::call] in existing pallets #8873

Closed
KiChjang opened this issue May 20, 2021 · 0 comments · Fixed by #8874
Closed

Remove empty #[pallet::hooks] or #[pallet::call] in existing pallets #8873

KiChjang opened this issue May 20, 2021 · 0 comments · Fixed by #8874
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code.

Comments

@KiChjang
Copy link
Contributor

With #8853 merged, the follow up would be to clean up any empty call or hooks in our list of existing pallets.
@KiChjang KiChjang added the Z0-trivial Writing the issue is of the same difficulty as patching the code. label May 20, 2021
@timgestson timgestson mentioned this issue May 20, 2021
Merged
@shawntabrizi shawntabrizi linked a pull request May 23, 2021 that will close this issue
Remove now unneeded empty hooks and calls #8873 #8874
Merged
@ghost ghost closed this as completed in #8874 May 23, 2021
ghost pushed a commit that referenced this issue May 23, 2021
@timgestson
Remove now unneeded empty hooks and calls #8873 (#8874)
c0be584 
* Remove now unneeded empty hooks and calls

* fix pallet_ui tests
nazar-pc pushed a commit to autonomys/substrate that referenced this issue Aug 8, 2021
@timgestson @nazar-pc
Remove now unneeded empty hooks and calls paritytech#8873 (paritytech…
e2a3cc3 
…#8874)

* Remove now unneeded empty hooks and calls

* fix pallet_ui tests
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove now unneeded empty hooks and calls #8873 timgestson/substrate
1 participant
@KiChjang