Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

ParityDb stabilization tracking #9201

Closed
5 tasks done
arkpar opened this issue Jun 24, 2021 · 1 comment
Closed
5 tasks done

ParityDb stabilization tracking #9201

arkpar opened this issue Jun 24, 2021 · 1 comment
Assignees
@debris
Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category.

Comments

@arkpar
Copy link
Member

arkpar commented Jun 24, 2021 •
edited
Loading

This lists all items that need to be complete to make parity-db the default backend in substrate

  • Implement an "auto" database backend for backward compatibility. It detects if rocksdb database already exists and uses it. Otherwise defaults to paritydb.
  • Finalize column settings. This includes size tier and compression settings.
  • Move polkadot specific storage to paritydb.
  • Make sure polkadot db is not using the same path as the main database. purge-chain should still delete both.
  • Run for two week on parity validators.
@arkpar arkpar added the J1-meta A specific issue for grouping tasks or bugs of a specific category. label Jun 24, 2021
@hirschenberger
Copy link
Contributor

Maybe in conjunction with this PR we can get this landed #8658

@debris debris self-assigned this Aug 4, 2021
@debris debris mentioned this issue Aug 4, 2021
Merged
debris added a commit that referenced this issue Aug 4, 2021
@debris
implement "auto" database backend in client/db, in progress, #9201
9d76e4e
@debris debris mentioned this issue Aug 4, 2021
Merged
ghost pushed a commit that referenced this issue Aug 9, 2021
@debris
DatabaseSource::Auto (#9500)
b9d86e1 
* implement "auto" database backend in client/db, in progress, #9201

* move fn supports_ref_counting from DatabaseSource enum to Database trait to make it work correctly for all types of dbs

* update kvdb_rocksdb to 0.13 and use it's new config feature  to properly auto start existing database

* tests for auto database reopening

* introduce OpenDbError to cleanup opening database error handling and handle case when database is not enabled at the compile time

* cargo fmt strings again

* cargo fmt strings again

* rename DataSettingsSrc to fix test compilation

* fix the call to the new kvdb-rocksdb interdace in tests to fix compilation

* simplify OpenDbError and make it compile even when paritydb and rocksdb are disabled

* cargo fmt

* fix compilation without flag with-parity-db

* fix unused var compilation warning

* support different paths for rocksdb and paritydb in DatabaseSouce::Auto

* support "auto" database option in substrate cli

* enable Lz4 compression for some of the parity-db colums as per review suggestion

* applied review suggestions
@arkpar arkpar closed this as completed Sep 6, 2022
@ordian ordian mentioned this issue Jul 24, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@debris debris

Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hirschenberger @debris @arkpar