This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Clear WASM linear memory on other OSes besides Linux too when using fast instance reuse #10291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10095
Originally I intended to just disable fast instance reuse when the
--import-memory
flag is not specified when compiling the runtime, however it seems we do already always clear the linear memory anyway (only on Linux) as a side-effect of #8998 so it seems to make more sense to just make this behavior official and apply to other OSes too?This might have a performance impact on non-Linux OSes, however: