This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
No longer include :code and :heappages in execution proofs #10419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
bkchr
approved these changes
Dec 3, 2021
kianenigma
approved these changes
Dec 3, 2021
arkpar
approved these changes
Dec 3, 2021
cheme
approved these changes
Dec 3, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for db9f59a |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…h#10419) * No longer include :code and :heap_pages in execution proofs * Oops, forgot the line * Rustfmt
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…h#10419) * No longer include :code and :heap_pages in execution proofs * Oops, forgot the line * Rustfmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm opening this PR very naively. I don't really understand the design of the code of the client, but if I'm not mistaken this should remove the fact that right now
:codeand:heappagesare included in every execution proof.This was the case because the Substrate light client is incapable of caching the runtime code. Smoldot, however, is completely capable of doing that. Now that the Substrate light client is dead, there's no reason to keep that behavior.
This should reduce by a few megabytes the size of execution proofs.
Close #5047