Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

allow tip value of 1 #10425

Merged
merged 5 commits into from
Dec 6, 2021
Merged

allow tip value of 1 #10425

merged 5 commits into from
Dec 6, 2021

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Dec 6, 2021

Previously tip value of 1 is same as zero. Now it actually makes difference.

Not important at all so feel free to close this one if you think the previous behavior is ok.

bkchr
bkchr approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the test, it looks good to me.

frame/transaction-payment/src/lib.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from tomusdrw December 6, 2021 08:30
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 6, 2021
tomusdrw
tomusdrw approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is only for priority calculations and yeah, perhaps it is more elegant to add one than to have a minimum value.

@bkchr bkchr merged commit 0e6cc56 into paritytech:master Dec 6, 2021
@xlc xlc deleted the improve-tip branch December 6, 2021 19:25
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@xlc @grishasobol
allow tip value of 1 (paritytech#10425)
499b1dc 
* allow tip value of 1

* update comment

* fmt

* update test

* fmt
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@xlc @ark0f
allow tip value of 1 (paritytech#10425)
638fef3 
* allow tip value of 1

* update comment

* fmt

* update test

* fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xlc @tomusdrw @bkchr