Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Prepare sp-runtime for publication #10451

Merged
merged 10 commits into from
Dec 15, 2021
Merged

Prepare sp-runtime for publication #10451

merged 10 commits into from
Dec 15, 2021

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Dec 8, 2021 •
edited
Loading

Prepare sp-runtime for publication.

Screenshot 2021-12-10 at 14 58 51

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 8, 2021
@dvdplm dvdplm requested review from bkchr, insipx and jsdw December 8, 2021 21:25
@dvdplm dvdplm self-assigned this Dec 8, 2021
@dvdplm dvdplm added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 8, 2021
@dvdplm dvdplm requested review from niklasad1 and jsdw and removed request for jsdw December 9, 2021 10:33
niklasad1
niklasad1 approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

needs a polkadot companion though.

@dvdplm
Copy link
Contributor Author

dvdplm commented Dec 10, 2021

needs a polkadot companion though.

I don't think I can open a companion before the crates are published. I'll make one as soon as the crates from this PR are published.

@bkchr
Copy link
Member

bkchr commented Dec 15, 2021

needs a polkadot companion though.

I don't think I can open a companion before the crates are published. I'll make one as soon as the crates from this PR are published.

Ignore it.

@bkchr bkchr merged commit 50ab759 into master Dec 15, 2021
@bkchr bkchr deleted the dp-release-sp-runtime branch December 15, 2021 11:36
seunlanlege pushed a commit to seunlanlege/substrate that referenced this pull request Dec 17, 2021
@dvdplm @seunlanlege
Prepare sp-runtime for publication (paritytech#10451)
c09a074 
* Bump versions of sp-core and dependencies to v4.0.0

* Update references from `4.0.0-dev` –> `4.0.0`

* Funny whitespace

* Funny whitespace 2

* Prepare `sp-runtime` for publication
@ascjones ascjones mentioned this pull request Feb 28, 2022
Merged
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@dvdplm @grishasobol
Prepare sp-runtime for publication (paritytech#10451)
fea9c0b 
* Bump versions of sp-core and dependencies to v4.0.0

* Update references from `4.0.0-dev` –> `4.0.0`

* Funny whitespace

* Funny whitespace 2

* Prepare `sp-runtime` for publication
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@dvdplm @ark0f
Prepare sp-runtime for publication (paritytech#10451)
1d065ad 
* Bump versions of sp-core and dependencies to v4.0.0

* Update references from `4.0.0-dev` –> `4.0.0`

* Funny whitespace

* Funny whitespace 2

* Prepare `sp-runtime` for publication
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@insipx insipx insipx approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@adoerr adoerr Awaiting requested review from adoerr

@andresilva andresilva Awaiting requested review from andresilva

@athei athei Awaiting requested review from athei athei is a code owner

@kianenigma kianenigma Awaiting requested review from kianenigma

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@jsdw jsdw Awaiting requested review from jsdw

@acatangiu acatangiu Awaiting requested review from acatangiu acatangiu is a code owner

Assignees

@dvdplm dvdplm

Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvdplm @bkchr @insipx @niklasad1