This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
move generics of election trait to associated types #10475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A2-insubstantial
19 tasks
kianenigma
added
A0-please_review
bkchr
approved these changes
Dec 12, 2021
emostov
approved these changes
Dec 13, 2021
|
It is also not compiling :D |
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 9194158 |
…ork-election-trait-generics
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
kiz-rework-election-trait-generics
branch
seunlanlege
pushed a commit
to seunlanlege/substrate
that referenced
this pull request
Dec 17, 2021
* move generics of election trait to associated types * fix doctest
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* move generics of election trait to associated types * fix doctest
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* move generics of election trait to associated types * fix doctest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero logical change, just swaps the generics of two of the election traits to make it less noisy to use. We never use the generic with a degree of flexibility that we can't achieve with associated types.
part of paritytech/polkadot-sdk#461