Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Derive TypeInfo for OpaqueExtrinsic #10504

Merged

Conversation

liuchengxu
Copy link
Contributor

No description provided.

@bkchr
Copy link
Member

bkchr commented Dec 17, 2021

Do you use this somewhere in the runtime?

@liuchengxu
Copy link
Contributor Author

Do you use this somewhere in the runtime?

Exactly, was trying to use it in runtime because somehow the main runtime only cares about the extrinsic blob. Eventually, we would get rid of the approach loading the full opaque extrinsic, but it can still be nice to have this derive anyway if that doesn't hurt.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 17, 2021
@bkchr
Copy link
Member

bkchr commented Dec 17, 2021

@liuchengxu next time please add a little bit of description on "why". ty.

@liuchengxu
Copy link
Contributor Author

@bkchr Will do, I thought it's a mere fairly trivial change and made a really quick PR :(.

@bkchr
Copy link
Member

bkchr commented Dec 17, 2021

bot merge

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit a404abd into paritytech:master Dec 17, 2021
@bkchr
Copy link
Member

bkchr commented Dec 17, 2021

@bkchr Will do, I thought it's a mere fairly trivial change and made a really quick PR :(.

I know, but I'm still interested on a why. Otherwise I will need to ask again and wait and bla. Could be faster :)

@liuchengxu liuchengxu deleted the OpaqueExtrinsic-type-info branch December 18, 2021 02:18
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants