This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[WIP do not merge] Extract sc-network-sync crate #10514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
wigy-opensource-developer
force-pushed
the
wigy-sync-crate
branch
from
5870897 to
f046bf1
Compare
wigy-opensource-developer
changed the title
wigy-opensource-developer
added
B5-clientnoteworthy
B0-silent
wigy-opensource-developer
force-pushed
the
wigy-sync-crate
branch
from
f046bf1 to
9da15ae
Compare
wigy-opensource-developer
requested review from
acatangiu and
andresilva
as code owners
github-actions
bot
added
A0-please_review
|
This is my first PR with a companion, so I wanted to test it on CI. It is not ready for review yet, but draft PRs skip running CI. |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
|
Yip, still relevant. |
stale
bot
removed
the
A5-stale
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
|
Yeah. Hi, bot! I was distracted by other issues, but I am getting back to this. |
stale
bot
removed
the
A5-stale
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract synchronization related code into its own crate. This is the last protocol that was handled in a special way in the network crate.
closes: #8686
polkadot companion: paritytech/polkadot#4701