This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Expose Uniques helper functions and DestroyWitness fields #10529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shawntabrizi hi, opening PR as discussed, can you please have a look? |
shawntabrizi
approved these changes
Dec 28, 2021
shawntabrizi
added
B0-silent
bkchr
approved these changes
Dec 31, 2021
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We@Basilisk are planning to use our custom pallet-nft which is basically wrapped pallet-uniques with some customizations and extended permission functionality.
In order to use pallet-uniques' helper methods do_method we need to make them pub. Also need to make DestroyWitness fields pub to use them - e.g. need to prevent destroying classes which contain instances.