This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Relax types on DigestItemRef
, such that byte slices can be used in addition to vector references
#10536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to use
DigestItemRef
withframe_support::traits::FindAuthor
, so I can turn(ConsensusEngineId, &'a [u8])
intoDigestItemRef
without extra allocation:Ideally, I'd like to see
FindAuthor
having&'a DigestItem
instead of(ConsensusEngineId, &'a [u8])
if that is OK (this PR is still useful though).On a similar note
DigestItemRef
should really useConsensusEngineId
instead of&'a ConsensusEngineId
because reference will be more expensive to copy than the data itself.Technically this PR introduces a breaking change to the API, but it is extremely unlikely to be an issue in practice as the source of that iterator is almost certainly
Vec<DigestItem>
.