Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

frame/bench-cli: fix log formatting #10627

Merged
merged 1 commit into from
Jan 11, 2022
Merged

frame/bench-cli: fix log formatting #10627

merged 1 commit into from
Jan 11, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jan 10, 2022

  • Fix the progress log of benchmarks by adding spaces. \t seems to be ignored by the logger 🤷‍♂️
  • Let the counter indices in the progress start at 1 instead of 0.

Old output:

Benchmark:frame_benchmarkinghashing5/500/1

New output:

Running Benchmark: frame_benchmarking.hashing 20/20 1/1

@ggwpez
frame/bench-cli: fix log formatting
6040b78 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 10, 2022
@ggwpez ggwpez self-assigned this Jan 10, 2022
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 10, 2022
@shawntabrizi
Copy link
Member

bot merge

@paritytech-processbot paritytech-processbot bot merged commit daa4118 into master Jan 11, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-benchmark-log-fix branch January 11, 2022 03:18
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@ggwpez @grishasobol
frame/bench-cli: fix log formatting (paritytech#10627)
e0067ab 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@ggwpez @ark0f
frame/bench-cli: fix log formatting (paritytech#10627)
96cac71 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@bkchr bkchr bkchr approved these changes

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggwpez @shawntabrizi @bkchr