Update MMR Runtime API with functionality to generate MMR proof for a series of leaf indices #10635

Wizdave97 · 2022-01-11T13:06:34Z

This PR adds new functions to the MMR Runtime API to accept an array of leaf indexes, this would allow generating a proof for multiple leaf indices in one run if needed

Also added functions for verifying these kind of proof

Previous implementation of the PR here #10625
@rphmeier this is an updated fix for #10625 following your recommendation

polkadot companion: paritytech/polkadot#4700

stale · 2022-03-05T12:32:42Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

seunlanlege · 2022-03-05T22:06:21Z

Bump

stale · 2022-04-04T23:31:34Z

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

Wizdave97 · 2022-04-05T08:13:42Z

bump

seunlanlege · 2022-04-05T08:25:39Z

@acatangiu please could you take a look at this PR? The API it adds will be useful to parachain teams

acatangiu

I think most of these functions could be deduplicated if you just used primitives::BatchProof everywhere.

primitives::Proof is just a primitives::BatchProof with inner leaf_indices.len() == 1.

Since we don't want to break the API we can keep the non-batched runtime API functions at the runtime API level (we can also keep both versions for RPC), but everything underneath (frame/merkle-mountain-range/src/mmr/mmr.rs, frame/merkle-mountain-range/src/lib.rs) can have single implementation that works with BatchProof.

frame/merkle-mountain-range/src/lib.rs

frame/merkle-mountain-range/primitives/src/lib.rs

frame/merkle-mountain-range/src/mmr/mmr.rs

acatangiu · 2022-04-12T16:50:56Z

@Wizdave97 @seunlanlege sorry for the delay in review, I've only recently got acquainted with the MMR pallet and library.

Also FYI the MMR primitives are moved in #11183 ; so this PR should also rebase on top of that to get clean merge.

primitives/merkle-mountain-range/src/lib.rs

acatangiu

🚀

frame/merkle-mountain-range/rpc/src/lib.rs

frame/merkle-mountain-range/src/lib.rs

primitives/merkle-mountain-range/src/lib.rs

svyatonik

Couple of suggestions, otherwise seems good

frame/merkle-mountain-range/rpc/src/lib.rs

frame/merkle-mountain-range/src/mmr/mmr.rs

acatangiu · 2022-04-19T09:18:30Z

bot merge

paritytech-processbot · 2022-04-19T09:18:37Z

Error: "Check reviews" status is not passing for paritytech/polkadot#4700

…llow-batch-verification-of-leaves

acatangiu · 2022-04-28T09:05:50Z

bot merge

paritytech-processbot · 2022-04-28T09:05:57Z

Error: "Check reviews" status is not passing for paritytech/polkadot#4700

acatangiu · 2022-04-29T16:26:35Z

bot merge

paritytech-processbot · 2022-04-29T16:26:42Z

Error: "Check reviews" status is not passing for paritytech/polkadot#4700

…llow-batch-verification-of-leaves

acatangiu · 2022-05-03T12:58:07Z

primitives/merkle-mountain-range/src/lib.rs

+	/// Will panic if leaf indices length is less than 1
+	pub fn into_single_leaf_proof(proof: BatchProof<Hash>) -> Proof<Hash> {


I just noticed this and think we should do checked access and return Error::InvalidLeafIndices instead of unchecked access and panicking.

…llow-batch-verification-of-leaves

bin/node/runtime/src/lib.rs

acatangiu · 2022-05-04T10:40:04Z

bot merge

… series of leaf indices (paritytech#10635) * updated mmr rpc api with functions for batch generation of proof * update code comments * fix build errors * added tests to mmr-rpc * add tests to pallet-mmr * update comments * minor comment fix * remove unused variables * fix rust doc errors * refactor mmr runtime api * fix tests * minor fix * minor fix * fix node-runtime * revert to initial api * impl from proof fot batchproof * minor fix * minor fix * use explicit functions to convert btw batch proof and single proof * minor fix * add new variant to mmr error * fmt * update conversion to single leaf proof * fix style nit Co-authored-by: Adrian Catangiu <adrian@parity.io>

Wizdave97 marked this pull request as ready for review January 12, 2022 08:55

Wizdave97 mentioned this pull request Jan 12, 2022

Update MMR Runtime API - add proof batching paritytech/polkadot#4700

Merged

acatangiu self-requested a review January 13, 2022 12:02

rphmeier added the A0-please_review Pull request needs code review. label Jan 14, 2022

stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 5, 2022

stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 5, 2022

stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Apr 4, 2022

stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Apr 5, 2022

acatangiu requested a review from andresilva April 7, 2022 07:55

acatangiu suggested changes Apr 12, 2022

View reviewed changes

Wizdave97 force-pushed the david/allow-batch-verification-of-leaves branch from 5f002ab to 4132c67 Compare April 13, 2022 14:40

acatangiu reviewed Apr 14, 2022

View reviewed changes

primitives/merkle-mountain-range/src/lib.rs Outdated Show resolved Hide resolved

Wizdave97 requested a review from acatangiu April 15, 2022 11:51

acatangiu mentioned this pull request Apr 18, 2022

BEEFY: generate historical proofs #11230

Closed

acatangiu approved these changes Apr 18, 2022

View reviewed changes

acatangiu requested a review from svyatonik April 18, 2022 10:54

svyatonik reviewed Apr 18, 2022

View reviewed changes

frame/merkle-mountain-range/rpc/src/lib.rs Show resolved Hide resolved

frame/merkle-mountain-range/src/mmr/mmr.rs Show resolved Hide resolved

frame/merkle-mountain-range/src/mmr/mmr.rs Show resolved Hide resolved

svyatonik approved these changes Apr 18, 2022

View reviewed changes

acatangiu added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 19, 2022

updated mmr rpc api with functions for batch generation of proof

337b60e

Wizdave97 added 8 commits April 27, 2022 13:14

impl from proof fot batchproof

000492c

minor fix

c862af0

minor fix

fdada33

use explicit functions to convert btw batch proof and single proof

9674732

minor fix

4eb167d

add new variant to mmr error

f1a9860

fmt

be0f200

Merge branch 'master' of github.com:paritytech/substrate into david/a…

590eae9

…llow-batch-verification-of-leaves

Wizdave97 force-pushed the david/allow-batch-verification-of-leaves branch from 26a16e1 to 590eae9 Compare April 27, 2022 12:15

Wizdave97 requested a review from acatangiu April 27, 2022 14:52

Merge branch 'master' of github.com:paritytech/substrate into david/a…

4734585

…llow-batch-verification-of-leaves

acatangiu suggested changes May 3, 2022

View reviewed changes

update conversion to single leaf proof

c099c7e

Wizdave97 requested a review from acatangiu May 3, 2022 15:35

Merge branch 'master' of github.com:paritytech/substrate into david/a…

9604387

…llow-batch-verification-of-leaves

acatangiu approved these changes May 4, 2022

View reviewed changes

acatangiu reviewed May 4, 2022

View reviewed changes

bin/node/runtime/src/lib.rs Outdated Show resolved Hide resolved

fix style nit

e0f00fa

paritytech-processbot bot merged commit 636ffa4 into paritytech:master May 4, 2022

Wizdave97 deleted the david/allow-batch-verification-of-leaves branch May 4, 2022 11:40

acatangiu mentioned this pull request Jun 28, 2022

pallet-mmr: batch proofs are sometimes broken #11753

Closed

2 tasks

Wizdave97 mentioned this pull request Oct 8, 2022

Member request polkadot-fellows/seeding#38

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update MMR Runtime API with functionality to generate MMR proof for a series of leaf indices #10635

Update MMR Runtime API with functionality to generate MMR proof for a series of leaf indices #10635

Wizdave97 commented Jan 11, 2022 •

edited

Loading

stale bot commented Mar 5, 2022

seunlanlege commented Mar 5, 2022

stale bot commented Apr 4, 2022

Wizdave97 commented Apr 5, 2022

seunlanlege commented Apr 5, 2022

acatangiu left a comment

acatangiu commented Apr 12, 2022 •

edited

Loading

acatangiu left a comment

svyatonik left a comment

acatangiu commented Apr 19, 2022

paritytech-processbot bot commented Apr 19, 2022

acatangiu commented Apr 28, 2022

paritytech-processbot bot commented Apr 28, 2022

acatangiu commented Apr 29, 2022

paritytech-processbot bot commented Apr 29, 2022

acatangiu May 3, 2022

acatangiu commented May 4, 2022

		/// Will panic if leaf indices length is less than 1
		pub fn into_single_leaf_proof(proof: BatchProof<Hash>) -> Proof<Hash> {

Update MMR Runtime API with functionality to generate MMR proof for a series of leaf indices #10635

Update MMR Runtime API with functionality to generate MMR proof for a series of leaf indices #10635

Conversation

Wizdave97 commented Jan 11, 2022 • edited Loading

stale bot commented Mar 5, 2022

seunlanlege commented Mar 5, 2022

stale bot commented Apr 4, 2022

Wizdave97 commented Apr 5, 2022

seunlanlege commented Apr 5, 2022

acatangiu left a comment

Choose a reason for hiding this comment

acatangiu commented Apr 12, 2022 • edited Loading

acatangiu left a comment

Choose a reason for hiding this comment

svyatonik left a comment

Choose a reason for hiding this comment

acatangiu commented Apr 19, 2022

paritytech-processbot bot commented Apr 19, 2022

acatangiu commented Apr 28, 2022

paritytech-processbot bot commented Apr 28, 2022

acatangiu commented Apr 29, 2022

paritytech-processbot bot commented Apr 29, 2022

acatangiu May 3, 2022

Choose a reason for hiding this comment

acatangiu commented May 4, 2022

Wizdave97 commented Jan 11, 2022 •

edited

Loading

acatangiu commented Apr 12, 2022 •

edited

Loading