This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use free balance rather than total balance for elections phragmen #10646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B7-runtimenoteworthy
C1-low
This was referenced Jan 13, 2022
|
#10649 targets this branch and adds a complementary migration. paritytech/polkadot#4710 applies the aforementioned migration to Polkadot and Kusama. |
kianenigma
approved these changes
Jan 13, 2022
emostov
approved these changes
Jan 13, 2022
|
bot merge |
paritytech-processbot
bot
deleted the
shawntabrizi-phragmen-free-balance
branch
bernardo-xxnet
pushed a commit
to xx-labs/substrate
that referenced
this pull request
Jan 15, 2022
…ritytech#10646) * use free balance rather than total balance * Docs Co-authored-by: emostov <32168567+emostov@users.noreply.github.com>
viniul
added
D1-audited 👍
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…ritytech#10646) * use free balance rather than total balance * Docs Co-authored-by: emostov <32168567+emostov@users.noreply.github.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…ritytech#10646) * use free balance rather than total balance * Docs Co-authored-by: emostov <32168567+emostov@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the maximum value a user can vote in Phragmen Elections, we should use the
free_balancerather than thetotal_balance, else the pallet can create locks larger than the user has available balance, and will be in constant debt to the lock even when transferring more funds.This update ensures we only allow voting up to the
free_balanceof the user, after any reserves have been placed for voting in the first place.