Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

bench/cli: extend --extrinsic name filtering #10677

Merged
merged 3 commits into from
Jan 18, 2022
Merged

bench/cli: extend --extrinsic name filtering #10677

merged 3 commits into from
Jan 18, 2022

Conversation

dharjeezy
Copy link
Contributor

make extrinsic argument contain list of comma separated extrinsic names as described in this issue paritytech/polkadot-sdk#401

Polkadot address: 12ZNas89oEagaxLVNbpqmvfMxdrGrqN7gJKSpwthTUPZsrku

@dharjeezy dharjeezy requested a review from ggwpez January 17, 2022 14:09
@ggwpez ggwpez added A4-awaitingci C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 17, 2022
@ggwpez
Copy link
Member

ggwpez commented Jan 17, 2022

bot merge

@paritytech-processbot
Copy link

Error: Approval criteria was not satisfied in #10677.

The following errors might have affected the outcome of this attempt:

Merge failed. Check out the criteria for merge. If you're not meeting the approval count, check if the approvers are team members of substrateteamleads or core-devs.

@dharjeezy
Copy link
Contributor Author

I See you merged @ggwpez
No tip? 😑😕

@shawntabrizi
Copy link
Member

@dharjeezy if you ask for a tip, you will not get one.

This PR is a diff of 5 lines, 2 of which is just formatting. We appreciate your contributions and excitement for Substrate / Polkadot, but not all of your work is really worthy of an on chain tip.

@dharjeezy
Copy link
Contributor Author

@dharjeezy if you ask for a tip, you will not get one.

This PR is a diff of 5 lines, 2 of which is just formatting. We appreciate your contributions and excitement for Substrate / Polkadot, but not all of your work is really worthy of an on chain tip.

Alright. Thanks!

kianenigma
kianenigma approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and hope to see further contributions!

@kianenigma
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 787bb87 into paritytech:master Jan 18, 2022
@ggwpez ggwpez mentioned this pull request Aug 24, 2023
Open
@librelois librelois mentioned this pull request Feb 7, 2022
Closed
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@dharjeezy @grishasobol
bench/cli: extend --extrinsic name filtering (paritytech#10677)
100af48 
* implement benchmarking multiple extrinsics

* ran cargo +nightly fmt

* remove contains check and made it an equals check
@dharjeezy dharjeezy mentioned this pull request Oct 17, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@dharjeezy @ark0f
bench/cli: extend --extrinsic name filtering (paritytech#10677)
1caa2fc 
* implement benchmarking multiple extrinsics

* ran cargo +nightly fmt

* remove contains check and made it an equals check
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@kianenigma kianenigma kianenigma approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dharjeezy @ggwpez @shawntabrizi @kianenigma