Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

use thiserror instead of derive_more for error handling #10696

Merged
merged 4 commits into from
Jan 25, 2022
Merged

use thiserror instead of derive_more for error handling #10696

merged 4 commits into from
Jan 25, 2022

Conversation

koushiro
Copy link
Contributor

Description

use thiserror instead of derive_more for error handling

Polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK

@koushiro
use thiserror instead of derive_more for error handling
c33a56a 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
bkchr
bkchr approved these changes Jan 25, 2022
View reviewed changes
utils/prometheus/src/lib.rs Outdated Show resolved Hide resolved
utils/prometheus/src/lib.rs Show resolved Hide resolved
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 25, 2022
@bkchr
Copy link
Member

bkchr commented Jan 25, 2022

Can you please merge master?

@koushiro
Copy link
Contributor Author

Can you please merge master?

Done

@bkchr
Copy link
Member

bkchr commented Jan 25, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit f2f9970 into paritytech:master Jan 25, 2022
@koushiro koushiro deleted the use-thiserror branch January 26, 2022 01:31
eskimor pushed a commit that referenced this pull request Jan 27, 2022
@koushiro @bkchr @eskimor
use thiserror instead of derive_more for error handling (#10696)
abce7d2 
* use thiserror instead of derive_more for error handling

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Update utils/prometheus/src/lib.rs

* Update utils/prometheus/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Wizdave97 pushed a commit to ComposableFi/substrate that referenced this pull request Feb 4, 2022
@koushiro @bkchr @Wizdave97
use thiserror instead of derive_more for error handling (parityte…
0a96049 
…ch#10696)

* use thiserror instead of derive_more for error handling

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Update utils/prometheus/src/lib.rs

* Update utils/prometheus/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
@koushiro koushiro mentioned this pull request Feb 10, 2022
Merged
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@koushiro @bkchr @grishasobol
use thiserror instead of derive_more for error handling (parityte…
7b6fdf6 
…ch#10696)

* use thiserror instead of derive_more for error handling

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Update utils/prometheus/src/lib.rs

* Update utils/prometheus/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@koushiro @bkchr @ark0f
use thiserror instead of derive_more for error handling (parityte…
486e6c8 
…ch#10696)

* use thiserror instead of derive_more for error handling

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Update utils/prometheus/src/lib.rs

* Update utils/prometheus/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paritytech-processbot paritytech-processbot[bot] paritytech-processbot[bot] approved these changes

@bkchr bkchr bkchr approved these changes

@acatangiu acatangiu Awaiting requested review from acatangiu

@andresilva andresilva Awaiting requested review from andresilva

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koushiro @bkchr