Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-scheduler: Fix migrations V2 to V3 #10757

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jan 30, 2022

V2 already supported origins, so we need to move them over instead of setting it to Root. Besides
that it also removes the custom Releases enum and moves it over to StorageVersion.

Fixes: #10754

V2 already supported origins, so we need to move them over instead of setting it to `Root`. Besides
that it also removes the custom `Releases` enum and moves it over to `StorageVersion`.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 30, 2022
@bkchr bkchr requested a review from kianenigma January 30, 2022 11:37
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chevdor chevdor added this to the v0.9.16 milestone Jan 31, 2022
@bkchr
Copy link
Member Author

bkchr commented Jan 31, 2022

bot merge

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit b07765f into master Jan 31, 2022
@paritytech-processbot paritytech-processbot bot deleted the bkchr-frame-scheduler-fix-migrations branch January 31, 2022 11:43
bkchr added a commit that referenced this pull request Jan 31, 2022
* pallet-scheduler: Fix migrations V2 to V3

V2 already supported origins, so we need to move them over instead of setting it to `Root`. Besides
that it also removes the custom `Releases` enum and moves it over to `StorageVersion`.

* Fixes

* Fixes

* 🤦
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* pallet-scheduler: Fix migrations V2 to V3

V2 already supported origins, so we need to move them over instead of setting it to `Root`. Besides
that it also removes the custom `Releases` enum and moves it over to `StorageVersion`.

* Fixes

* Fixes

* 🤦
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* pallet-scheduler: Fix migrations V2 to V3

V2 already supported origins, so we need to move them over instead of setting it to `Root`. Besides
that it also removes the custom `Releases` enum and moves it over to `StorageVersion`.

* Fixes

* Fixes

* 🤦
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad migration function for pallet-scheduler
3 participants