This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Child bounties comments #11053
Merged
Child bounties comments #11053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use uniform notion of parent and child, no "master" or "general" entity * README updated to match comments * `parent_index` used over simply `index`
nuke-web3
added
A0-please_review
nuke-web3
commented
Mar 16, 2022
nuke-web3
commented
Mar 16, 2022
nuke-web3
commented
Mar 16, 2022
Comment on lines
+21
to
+26
| This pallet may opt into using a [`ChildBountyManager`] that enables bounties to be split into | ||
| sub-bounties, as children of anh established bounty (called the parent in the context of it's | ||
| children). | ||
|
|
||
| > NOTE: The parent bounty cannot be closed if it has a non-zero number of it has active child | ||
| > bounties associated with it. |
There was a problem hiding this comment.
needs a check on my understanding
There was a problem hiding this comment.
You are right:
substrate/frame/bounties/src/lib.rs
Line 668 in 26ea757
nuke-web3
changed the title
parent_index used
nuke-web3
added
the
A2-insubstantial
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
stale
bot
removed
the
A5-stale
kianenigma
approved these changes
Apr 16, 2022
bkchr
approved these changes
Apr 16, 2022
bkchr
added
the
D3-trivial 🧸
|
bot merge |
|
Waiting for commit status. |
|
bot merge |
|
Waiting for commit status. |
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* * formatting * use uniform notion of parent and child, no "master" or "general" entity * README updated to match comments * `parent_index` used over simply `index` * rm `parent_*` change * parent_bounty_id * parent_index rm * fmt * Apply suggestions from code review
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* * formatting * use uniform notion of parent and child, no "master" or "general" entity * README updated to match comments * `parent_index` used over simply `index` * rm `parent_*` change * parent_bounty_id * parent_index rm * fmt * Apply suggestions from code review
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* * formatting * use uniform notion of parent and child, no "master" or "general" entity * README updated to match comments * `parent_index` used over simply `index` * rm `parent_*` change * parent_bounty_id * parent_index rm * fmt * Apply suggestions from code review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only comment changes, no logic impacted.