Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Short circuit Treasury::Spend benchmark for NeverEnsureOrigin #11562

Merged
merged 2 commits into from
May 31, 2022
Merged

Short circuit Treasury::Spend benchmark for NeverEnsureOrigin #11562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fb8734
Short circuit Treasury::Spend benchmark for NeverEnsureOrigin
ggwpez May 31, 2022
ad94ca6
Merge remote-tracking branch 'origin/master' into oty-treasury-spend-…
May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions frame/treasury/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,22 @@ fn assert_last_event<T: Config<I>, I: 'static>(generic_event: <T as Config<I>>::
}

benchmarks_instance_pallet! {
// This benchmark is short-circuited if `SpendOrigin` cannot provide
// a successful origin, in which case `spend` is un-callable and can use weight=0.
spend {
let (_, value, beneficiary_lookup) = setup_proposal::<T, _>(SEED);
let origin = T::SpendOrigin::successful_origin();
let origin = T::SpendOrigin::try_successful_origin();
let beneficiary = T::Lookup::lookup(beneficiary_lookup.clone()).unwrap();
let call = Call::<T, I>::spend { amount: value, beneficiary: beneficiary_lookup };
}: { call.dispatch_bypass_filter(origin)? }
}: {
if let Ok(origin) = origin.clone() {
call.dispatch_bypass_filter(origin)?;
}
}
verify {
assert_last_event::<T, I>(Event::SpendApproved { proposal_index: 0, amount: value, beneficiary }.into())
if origin.is_ok() {
assert_last_event::<T, I>(Event::SpendApproved { proposal_index: 0, amount: value, beneficiary }.into())
}
}

propose_spend {
Expand Down