This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bound pallet-scheduler #11589
Closed
Bound pallet-scheduler #11589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
github-actions
bot
added
the
A3-in_progress
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
commented
Jun 5, 2022
frame/scheduler/src/lib.rs
Outdated
| @@ -680,21 +898,23 @@ impl<T: Config> Pallet<T> { | |||
| ) -> Result<TaskAddress<T::BlockNumber>, DispatchError> { | |||
| let when = Self::resolve_time(when)?; | |||
| call.ensure_requested::<T::PreimageProvider>(); | |||
| let call = EncodedCallOrHashOf::<T>::new(call)?; | |||
There was a problem hiding this comment.
used here @shawntabrizi @KiChjang
ggwpez
commented
Jun 5, 2022
frame/scheduler/src/lib.rs
Outdated
| #[derive(MaxEncodedLen, Debug, Decode, Clone, Encode, PartialEq, Eq, scale_info::TypeInfo)] | ||
| #[codec(mel_bound(T: Config))] | ||
| #[scale_info(skip_type_params(T))] | ||
| pub struct EncodedCallOrHashOf<T: Config>(pub BoundedVec<u8, <T as Config>::MaxCallLen>); |
There was a problem hiding this comment.
defined here @shawntabrizi @KiChjang
KiChjang
reviewed
Jun 5, 2022
frame/scheduler/src/lib.rs
Outdated
| @@ -93,12 +123,49 @@ struct ScheduledV1<Call, BlockNumber> { | |||
| maybe_periodic: Option<schedule::Period<BlockNumber>>, | |||
| } | |||
|
|
|||
| // NOTE: use `Derivative` here until <https://github.com/rust-lang/rust/issues/26925> is fixed. | |||
| // The problem is that `#[derive(Clone)]` requires `Clone` for ALL its generic types, | |||
| // which does not make sense for `Get<>`. | |||
There was a problem hiding this comment.
This means you should derive CloneNoBound.
There was a problem hiding this comment.
Was looking for something like this. Thank you, sir!
dvdplm
reviewed
Jun 5, 2022
| @@ -231,11 +310,37 @@ pub mod pallet { | |||
| /// be used. This will only check if two given origins are equal. | |||
| type OriginPrivilegeCmp: PrivilegeCmp<Self::PalletsOrigin>; | |||
|
|
|||
| /// Maximum number of tasks that an be scheduled in total. | |||
There was a problem hiding this comment.
Suggested change
| /// Maximum number of tasks that an be scheduled in total. | |
| /// Maximum number of tasks that can be scheduled in total. |
|
|
||
| if Agenda::<T>::try_append(until, s).is_err() { | ||
| // There is not enough room in the future block where the call | ||
| // should be re-scheduled. Nothing that we can do about it. |
There was a problem hiding this comment.
I will maybe emit a Canceled event here, last time I tried ti somehow did not work.
But yea, a log would also be useful.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
2 tasks
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Superseded by #11649 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11565
WIP:
CallandOriginCallerChanges:
MaxScheduledPerBlockis now a hard instead of soft limit.Problems:
schedulecall is currently guaranteed to succeed if called with valid arguments. If we now bound the number of agendas per block because ofMaxEncodedLen, then someone could pre-fill a block with agendas and the governanceschedulecall would fail. Currently this is not a problem since the number of schedules per block is unbound.Special attention from reviews please:
current_storage_versiontoon_chain_current_storage_versionas it otherwise does not verify that the migration updated the storage versionEvent::CallLookupFailedis unused, can I just remove it?