This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add era to Unbonded event
#11770
Merged
Add era to Unbonded event
#11770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Jul 19, 2022
| @@ -1288,6 +1288,7 @@ pub mod pallet { | |||
| pool_id: PoolId, | |||
| balance: BalanceOf<T>, | |||
| points: BalanceOf<T>, | |||
| era: EraIndex, | |||
There was a problem hiding this comment.
Update the docs to say what is era please? is it the era in which we unbonded, or the one in which we will be unlocked?
kianenigma
approved these changes
Jul 19, 2022
kianenigma
added
A0-please_review
|
needs to merge master. |
shawntabrizi
approved these changes
Jul 19, 2022
|
any updates @hirschenberger? |
Sorry @kianenigma was busy the last days. I will will fix your suggestions asap. |
# Conflicts: # frame/nomination-pools/src/tests.rs
kianenigma
approved these changes
Jul 25, 2022
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 8fa5cc3 |
|
bot rebase |
|
Rebased |
|
bot merge |
kianenigma
added
B7-runtimenoteworthy
and removed
B0-silent
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Add era to `Unbonded` event fixes paritytech#11749 * Fix missing tests * Add comment for `era` field in `Unbonded` struct. Co-authored-by: parity-processbot <>
2 tasks
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Add era to `Unbonded` event fixes paritytech#11749 * Fix missing tests * Add comment for `era` field in `Unbonded` struct. Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11749